Add more detailed WPT test coverage for stopping behavior. #33815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 27, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3609997
branch
2 times, most recently
from
32389c5
to
66b592d
Compare
The added tests aim to cover: - When transceiver.recevier.track should or should not end. - When transceiver is stopped locally versus remotely. - When the transceiver is "stopping" or "stopped". - When transceiver is stopped due to being removed in a rollback versus being rolled back without being removed. The -expected.txt file reflects https://crbug.com/1315611 being fixed, but the following issues have not been fixed yet which FAIL: - https://crbug.com/1319913: direction is not updated to "stopped" if transceiver is stopped remotely. - https://crbug.com/1319911: currentDirection is not updated to "stopped" when already "stopping" and answer removes the transceiver. // Test coverage for the following issues: Bug: 1315611, 1319902, 1319911, 1319913, 1319924 Change-Id: I8ad97221f5d2171384e8c7be32eaabd9811ba8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3609997 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#997067}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3609997
branch
from
66b592d
to
4c10acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added tests aim to cover:
being rolled back without being removed.
The -expected.txt file reflects https://crbug.com/1315611 being fixed,
but the following issues have not been fixed yet which FAIL:
transceiver is stopped remotely.
"stopped" when already "stopping" and answer removes the transceiver.
// Test coverage for the following issues:
Bug: 1315611, 1319902, 1319911, 1319913, 1319924
Change-Id: I8ad97221f5d2171384e8c7be32eaabd9811ba8f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3609997
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#997067}