[Gecko Bug 1719505] [wdspec] Improvements for WebDriver BiDi Python client. #33869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 29, 2022
The "session.new" command currently doesn't work because the transport is started after sending the command. This needed to be flipped. Also it is helpful to have the event loop of the current transport available as property on the BiDi session directly. Differential Revision: https://phabricator.services.mozilla.com/D144979 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1719505 gecko-commit: 7ac82aff1852eaf89acc99714a7359596b093d2a gecko-reviewers: webdriver-reviewers, jgraham
moz-wptsync-bot
force-pushed
the
gecko/1719505
branch
from
f485d2e
to
eeca036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "session.new" command currently doesn't work because the
transport is started after sending the command. This needed
to be flipped.
Also it is helpful to have the event loop of the current
transport available as property on the BiDi session directly.
Differential Revision: https://phabricator.services.mozilla.com/D144979
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1719505
gecko-commit: 3e3df2a6b1e38e417ec1c4f234fda2b9f474366b
gecko-reviewers: webdriver-reviewers, jgraham