Add test for :has(:target) change #33890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
:targetchanges, CSS properties via:has(:target)don't seem to be applied.Here's a video demonstrating the problem in Safari Version 15.4 (17613.1.17.1.13).
has-target.mov
As shown, the rules are there, but the page only updates when I manually edit the stylesheet via inspector.
It does not work on the following browser/versions I've tested with:
Worth noting–on the test page, if I manually click the fragment links, the text colors would not update (which is what this test is for); but while running the automatic test, the text color is updated on
:targetchange, even though the assertion does still fail.