Set fragment index to 0 when hit-testing in non-fragmented container. #33894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 2, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3620315
branch
2 times, most recently
from
8cf98fe
to
f04f65d
Compare
Set the fragment index to 0, instead of leaving it at WTF::kNotFound, when AppendSingleFragmentForHitTesting() has no container_fragment specified. container_fragment is nullptr as an optimization, when the container only has one fragment. See near the end of HitTestLayerByApplyingTransform(). Bug: 1321302 Change-Id: Ibf6bfce2308229030304d99588defd9494ec0298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3620315 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1000919}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3620315
branch
from
f04f65d
to
933849f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the fragment index to 0, instead of leaving it at WTF::kNotFound,
when AppendSingleFragmentForHitTesting() has no container_fragment
specified. container_fragment is nullptr as an optimization, when
the container only has one fragment. See near the end of
HitTestLayerByApplyingTransform().
Bug: 1321302
Change-Id: Ibf6bfce2308229030304d99588defd9494ec0298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3620315
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000919}