Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete function in COOP WPTs. #33932

Merged
merged 1 commit into from May 6, 2022
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 4, 2022

percent_encode was used for a single test case in COOP parsing. That
test case does not use url_test anymore and can be removed.

See https://chromium-review.googlesource.com/c/chromium/src/+/3620319

Bug: 1318373
Change-Id: I2c0d5bab35841711357b0dcc43410fad9be863eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627538
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999430}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

percent_encode was used for a single test case in COOP parsing. That
test case does not use url_test anymore and can be removed.

See https://chromium-review.googlesource.com/c/chromium/src/+/3620319

Bug: 1318373
Change-Id: I2c0d5bab35841711357b0dcc43410fad9be863eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627538
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999430}
@KyleJu
Copy link
Contributor

KyleJu commented May 5, 2022

The flakiness is existing. @past please admin merge

@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/javascript-url.https.html?0-3 navigation: SAME_SITE; parentCOOP: unsafe-none; childCOOP: unsafe-none PASS: 1/2, TIMEOUT: 1/2 Test timed out
/html/cross-origin-opener-policy/javascript-url.https.html?0-3 navigation: SAME_SITE; parentCOOP: unsafe-none; childCOOP: same-origin-allow-popups PASS: 1/2, TIMEOUT: 1/2 Test timed out

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@hemeryar
Copy link
Contributor

hemeryar commented May 6, 2022

COOP tests are indeed known to flake on the WPT CI. This change is a no-op.

@past past merged commit f90d75b into master May 6, 2022
@past past deleted the chromium-export-cl-3627538 branch May 6, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants