[FedCM] Only compare origins, not paths, for CSP checks #33976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 7, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3630577
branch
7 times, most recently
from
0b91222
to
db02567
Compare
For compatibility with existing deployments, only compare origins. This has been discussed and agreed with Chrome Security in https://docs.google.com/document/d/16OwWXqg4tueno7xkQU7TPrF-qJle3KFqRUMHCFQ3rug/edit Fixed: 1320724 Change-Id: I2758727149757cef835cd10b4c4d04897f234098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3630577 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/main@{#1002743}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3630577
branch
from
db02567
to
25c8ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with existing deployments, only compare origins.
This has been discussed and agreed with Chrome Security in
https://docs.google.com/document/d/16OwWXqg4tueno7xkQU7TPrF-qJle3KFqRUMHCFQ3rug/edit
Fixed: 1320724
Change-Id: I2758727149757cef835cd10b4c4d04897f234098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3630577
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002743}