Revert "[Trusted Types] Get list of event handlers from WebIDL" #34060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20acdd57bc0c2900456a9717629834686cdb4890. Reason for revert: Breaks Deterministic builders on debug builds, likely due to the Python build action. Linux failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux%20(dbg)/25817/overview Fuchsia failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Fuchsia%20(dbg)/12090/overview Original change's description: > [Trusted Types] Get list of event handlers from WebIDL > > This change retrieves the list of attributes declared as event handlers > from WebIDL and uses that to check for TrustedScript, instead of using > the string prefix "on". > > Bug: 993268, 1084587 > Change-Id: Ic15bc0994bcd19d9d7385cbef4af0f01af820ae1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616765 > Reviewed-by: Mason Freed <masonf@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Yifan Luo <lyf@chromium.org> > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1003034} Bug: 993268, 1084587 Change-Id: I0ba65a80617dd027eb7903192843fa8700a4c56a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648222 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: David Song <wintermelons@google.com> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003215}
wpt-pr-bot
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 20acdd57bc0c2900456a9717629834686cdb4890.
Reason for revert: Breaks Deterministic builders on debug builds, likely due to the Python build action.
Linux failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux%20(dbg)/25817/overview
Fuchsia failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Fuchsia%20(dbg)/12090/overview
Original change's description:
Bug: 993268, 1084587
Change-Id: I0ba65a80617dd027eb7903192843fa8700a4c56a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648222
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: David Song <wintermelons@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1003215}