Refactor tests to remove dependency on offsets. #34082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 16, 2022
Remove start, end, and scroll-offset from scroll-linked animation CSS tests. The parameters "start" and "end" do not align with the current spec, and "scroll-offset" is likely to be phased out in the spec rewrite. A consistent scroll range can be obtained by using overflow: hidden and a ratio of the content height to container height. Bug: 1326242 Change-Id: I0925ae0dbf323cc409dd7f3a272b22a6d9e17525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3647734 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004365}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3647734
branch
from
1b6c4c3
to
0ba84f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove start, end, and scroll-offset from scroll-linked animation
CSS tests. The parameters "start" and "end" do not align with the
current spec, and "scroll-offset" is likely to be phased out in the
spec rewrite.
A consistent scroll range can be obtained by using overflow: hidden
and a ratio of the content height to container height.
Bug: 1326242
Change-Id: I0925ae0dbf323cc409dd7f3a272b22a6d9e17525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3647734
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1004365}