[WPT] Add incumbent/entry/relevant realm tests for Location/window.open #34087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 17, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3646085
branch
5 times, most recently
from
74f2415
to
0664e84
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3646085
branch
2 times, most recently
from
71657e2
to
650d38f
Compare
Based on Chromium layout tests. Current test failures: The settings object used for `document.referrer` (=navigation request's client) are: - The incumbent settings for `window.open()` on Chrome. - The `Location`'s relevant for `location.assign()` on Safari. Change-Id: I6b50f886985fb21b4e8a1f7138744e1cce205534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646085 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005006}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3646085
branch
from
650d38f
to
33c6cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Chromium layout tests.
Current test failures:
The settings object used for
document.referrer(=navigation request's client) are:
window.open()on Chrome.Location's relevant forlocation.assign()on Safari.Change-Id: I6b50f886985fb21b4e8a1f7138744e1cce205534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646085
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1005006}