Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't subtract border-spacing that was optimistically added. #34110

Merged
merged 1 commit into from May 19, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 18, 2022

With LayoutUnit saturated arithmetic we could get a table box extent
with an end offset above the start offset.

Bug: 1326276
Change-Id: Iff328bb7557c5b70b6c070048a21a55a82f116da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652324
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1005114}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

With LayoutUnit saturated arithmetic we could get a table box extent
with an end offset above the start offset.

Bug: 1326276
Change-Id: Iff328bb7557c5b70b6c070048a21a55a82f116da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652324
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1005114}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants