Return focus to previously-focused element on popup hide #34116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 18, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3627159
branch
5 times, most recently
from
75ecf3b
to
a14b58b
Compare
Akin to <dialog>'s behavior, the desired behavior is that focus is returned to the previously-focused element when a popup is hidden: openui/open-ui#327 Bug: 1307772 Change-Id: Ia6ae1981612a0c0150b8b5f51b485a00a9a90de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627159 Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1006180}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3627159
branch
from
a14b58b
to
15c3100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Akin to <dialog>'s behavior, the desired behavior is that focus
is returned to the previously-focused element when a popup is
hidden:
openui/open-ui#327
Bug: 1307772
Change-Id: Ia6ae1981612a0c0150b8b5f51b485a00a9a90de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627159
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1006180}