[Sheriff] Fix anonymous iframe WPT #34125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 19, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3654181
branch
from
3a46c83
to
2606312
Compare
The test was flaky because of a race. In some cases, the iframe's document body does not exist yet when the test tries to attach childrens to it. I believe the reason is that the test was relying on the iframe's window location to know whether the iframe loaded. I think the location is not guaranteed to be updated after the iframe document has loaded. Example of a failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/105109/overview Bug: 1251084 Change-Id: I78f3dd34a9d98d2d057d27dc993cb624fd0ae84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654181 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Auto-Submit: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005218}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3654181
branch
from
2606312
to
325102f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was flaky because of a race. In some cases, the iframe's document body does not exist yet when the test tries to attach childrens to it. I believe the reason is that the test was relying on the iframe's window location to know whether the iframe loaded. I think the location is not guaranteed to be updated after the iframe document has loaded.
Example of a failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/105109/overview
Bug: 1251084
Change-Id: I78f3dd34a9d98d2d057d27dc993cb624fd0ae84b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654181
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Auto-Submit: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1005218}