Adding more tests to css-grid/animation #34137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 19, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3591246
branch
from
a331d93
to
5a49bb6
Compare
|
I'm working on Chromium's implementation of grid-template animations. I noticed there are a few test cases missing. @BorisChiou would you mind taking a look since you've added the original ones? |
|
Sure. Will check this patch soon. |
BorisChiou
approved these changes
May 23, 2022
Thank you for the review! |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3591246
branch
from
5a49bb6
to
42e8640
Compare
This CL adds test cases to grid-template-rows-interpolation.html and grid-template-columns-interpolation.html, as well as new tests for composition of grid-template-columns and grid-template-rows. Bug: 759665 Change-Id: Ibf77a550964732aa12773342a117b96529b1215c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591246 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1007077}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3591246
branch
from
42e8640
to
f56fe4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds test cases to grid-template-rows-interpolation.html and
grid-template-columns-interpolation.html, as well as new tests for
composition of grid-template-columns and grid-template-rows.
Bug: 759665
Change-Id: Ibf77a550964732aa12773342a117b96529b1215c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591246
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1007077}