[Gecko Bug 1770729] Fix IntersectionObserver overflow: clip on zero-sized elements. #34166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized my fix in bug 1769512 (using IsEmpty()) wasn't quite correct in this case, because IntersectionObserver preserves edge-inclusive intersections. Differential Revision: https://phabricator.services.mozilla.com/D147078 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1770729 gecko-commit: 6fb2ab75b12bbd9708b2476aa2c5e520b776ff02 gecko-reviewers: jwatt
wpt-pr-bot
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized my fix in bug 1769512 (using IsEmpty()) wasn't quite correct
in this case, because IntersectionObserver preserves edge-inclusive
intersections.
Differential Revision: https://phabricator.services.mozilla.com/D147078
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1770729
gecko-commit: 6fb2ab75b12bbd9708b2476aa2c5e520b776ff02
gecko-reviewers: jwatt