Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revamp object-not-found redirect resource timing tests" #34301

Merged
merged 1 commit into from Jun 6, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 3, 2022

This reverts commit f1fda133e0491f023d674167e36e04bd1da4061b.

Reason for revert: likely caused linux-bfcache-rel CI failures.

Example failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/33293/overview

Original change's description:

Revamp object-not-found redirect resource timing tests

I suspect that the object resource timing tests are flakily timing out
due to flakiness in <object>'s events themselves.

This CL moves these tests to the more recent resource timing testing
infrastructure, and also ends the test once a PerformanceObserver runs
its callback.

Bug: 1318592
Change-Id: I2b01188756b212b51b8c8d095a2257d4a0e54e91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3682424
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010553}

Bug: 1332556, 1318592
Change-Id: I99dc11ffa01158bcd2c0e1814ff5df4c3a158d7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688576
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Igor Ruvinov <igorruvinov@chromium.org>
Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010593}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This reverts commit f1fda133e0491f023d674167e36e04bd1da4061b.

Reason for revert: likely caused linux-bfcache-rel CI failures.

Example failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/33293/overview

Original change's description:
> Revamp object-not-found redirect resource timing tests
>
> I suspect that the object resource timing tests are flakily timing out
> due to flakiness in <object>'s events themselves.
>
> This CL moves these tests to the more recent resource timing testing
> infrastructure, and also ends the test once a PerformanceObserver runs
> its callback.
>
> Bug: 1318592
> Change-Id: I2b01188756b212b51b8c8d095a2257d4a0e54e91
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3682424
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1010553}

Bug: 1332556, 1318592
Change-Id: I99dc11ffa01158bcd2c0e1814ff5df4c3a158d7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688576
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Igor Ruvinov <igorruvinov@chromium.org>
Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010593}
@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/resource-timing/object-not-found-adds-entry.html Verify that a 200 null-typed object emits an entry. FAIL: 1/10, PASS: 9/10 assert_greater_than: encodedBodySize should be greater than 0 expected a number greater than 0 but got 0
/resource-timing/object-not-found-adds-entry.html Verify that a 404 null-typed object emits an entry. FAIL: 1/10, PASS: 9/10 assert_greater_than: encodedBodySize should be greater than 0 expected a number greater than 0 but got 0
/resource-timing/object-not-found-adds-entry.html Verify that a 404 img-typed object emits an entry. FAIL: 2/10, PASS: 8/10 assert_greater_than: encodedBodySize should be greater than 0 expected a number greater than 0 but got 0

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX
Copy link
Contributor

@past can you help admin merge this, as this is a revert? Thanks!

@WeizhongX WeizhongX closed this Jun 3, 2022
@WeizhongX WeizhongX reopened this Jun 3, 2022
@past past merged commit 4229253 into master Jun 6, 2022
@past past deleted the chromium-export-cl-3688576 branch June 6, 2022 16:50
@past
Copy link
Member

past commented Jun 6, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants