New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revamp object-not-found redirect resource timing tests" #34301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
This reverts commit f1fda133e0491f023d674167e36e04bd1da4061b. Reason for revert: likely caused linux-bfcache-rel CI failures. Example failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/33293/overview Original change's description: > Revamp object-not-found redirect resource timing tests > > I suspect that the object resource timing tests are flakily timing out > due to flakiness in <object>'s events themselves. > > This CL moves these tests to the more recent resource timing testing > infrastructure, and also ends the test once a PerformanceObserver runs > its callback. > > Bug: 1318592 > Change-Id: I2b01188756b212b51b8c8d095a2257d4a0e54e91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3682424 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1010553} Bug: 1332556, 1318592 Change-Id: I99dc11ffa01158bcd2c0e1814ff5df4c3a158d7d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688576 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Igor Ruvinov <igorruvinov@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1010593}
2a2a7b3
to
bedc197
Compare
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
@past can you help admin merge this, as this is a revert? Thanks! |
Merged, thanks! |
This reverts commit f1fda133e0491f023d674167e36e04bd1da4061b.
Reason for revert: likely caused linux-bfcache-rel CI failures.
Example failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/33293/overview
Original change's description:
Bug: 1332556, 1318592
Change-Id: I99dc11ffa01158bcd2c0e1814ff5df4c3a158d7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688576
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Igor Ruvinov <igorruvinov@chromium.org>
Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010593}