Add text-align-last reference test from Blink #34308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
frivoal,
kojiishi,
nox,
plinss and
r12a
nt1m
changed the title
emilio
approved these changes
Jun 4, 2022
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Jun 4, 2022
https://bugs.webkit.org/show_bug.cgi?id=241301 <rdar://94384891> Reviewed by Alan Bujtas. `text-align: justify` already worked for the legacy line layout, but not in IFC. Add support for it and a corresponding WPT. Also removed `text-justify: none` handling from legacy line layout, since IFC doesn't handle it, and legacy line layout also doesn't handle it correctly either. Thankfully `text-justify` is disabled by default. * LayoutTests/TestExpectations: * LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Removed. * LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Removed. Removed tests that were wrong, compared with other browsers to verify. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last.html: Added. WPT is from Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/css3-text/css3-text-align-last/text-align-last.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63 Upstream WPT PR: web-platform-tests/wpt#34308 * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::applyRunExpansion): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::close): * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::textAlignmentForLine const): Canonical link: https://commits.webkit.org/251311@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/css3-text/css3-text-align-last/text-align-last.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63