Skip multicol block-size calculation for table cells. #34610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 27, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3726071
branch
from
0b59246
to
0f9bca4
Compare
Table cell sizing is special, and if a table cell is also a multicol container, skip the manual multicol-specific pre-layout sizing, as that only messes up things. Add some tests. Note that only table-cell-multicol-nested-002.html was failing without this CL, but they all prove that we need to apply outer fragmentation context constraints before bailing. Bug: 1335873 Change-Id: I7a0b1c1428a01e67df1d782d5028136d8d8fb5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3726071 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1018416}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3726071
branch
from
0f9bca4
to
97c97d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table cell sizing is special, and if a table cell is also a multicol
container, skip the manual multicol-specific pre-layout sizing, as that
only messes up things.
Add some tests. Note that only table-cell-multicol-nested-002.html was
failing without this CL, but they all prove that we need to apply outer
fragmentation context constraints before bailing.
Bug: 1335873
Change-Id: I7a0b1c1428a01e67df1d782d5028136d8d8fb5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3726071
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018416}