Test the properties of SpeechSynthesisEvent #34710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly to check that they do not bubble. Follows WICG/speech-api#104.
4 tasks
Comment on lines
14
to
15
| await test_driver.bless('speechSynthesis.speak', | ||
| () => speechSynthesis.speak(utterance)); |
There was a problem hiding this comment.
Just so it's clear that speak doesn't actually return anything.
Suggested change
| await test_driver.bless('speechSynthesis.speak', | |
| () => speechSynthesis.speak(utterance)); | |
| await test_driver.bless('speechSynthesis.speak'); | |
| speechSynthesis.speak(utterance); |
There was a problem hiding this comment.
The 2nd argument here is intended to be used like this, the callback for the thing that needs a user gesture. But I can wrap in {} so that it doesn't matter what speechSynthesis.speak(utterance) returns.
There was a problem hiding this comment.
Understood. I generally don't bother using the bless' callback, as the click() resolves the bless' promise (enabling the transient activation). Just makes the code a bit easier on the eye.
But again, just a nit. All looks good 👍
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Jul 6, 2022
This applies a nit from web-platform-tests#34710 and makes the "unexpected event" bits more consistent.
foolip
added a commit
that referenced
this pull request
Mar 22, 2023
This applies a nit from #34710 and makes the "unexpected event" bits more consistent.
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
This is mainly to check that they do not bubble. Follows WICG/speech-api#104.
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
This applies a nit from #34710 and makes the "unexpected event" bits more consistent.
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Mar 29, 2023
This is mainly to check that they do not bubble. Follows WICG/speech-api#104.
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Mar 29, 2023
…m-tests#34716) This applies a nit from web-platform-tests#34710 and makes the "unexpected event" bits more consistent.
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
This is mainly to check that they do not bubble. Follows WICG/speech-api#104.
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
…m-tests#34716) This applies a nit from web-platform-tests#34710 and makes the "unexpected event" bits more consistent.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 13, 2023
…nd tinker with others, a=testonly Automatic update from web-platform-tests Make a speech synthesis fail fast and tinker with others (#34716) This applies a nit from web-platform-tests/wpt#34710 and makes the "unexpected event" bits more consistent. -- wpt-commits: 308366a5cf759241b5a8b1a4ab11ef3865625c22 wpt-pr: 34716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to check that they do not bubble.
Follows WICG/speech-api#104.