Correct column / column-group block size when fragmented. #34718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2022
We were effectively just using the block-size of the last table box fragment as block-size of table columns and column groups, since we were overwriting results from previous fragments. Instead, only pass this value when at the last table box fragment, and correctly exclude table border/padding and initial/final border-spacing. Bug: 1078927 Change-Id: If6424d961985d84495f388ff8b40aef4b2ce3034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747937 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1021348}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3747937
branch
from
b27029f
to
a01d42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were effectively just using the block-size of the last table box
fragment as block-size of table columns and column groups, since we were
overwriting results from previous fragments.
Instead, only pass this value when at the last table box fragment, and
correctly exclude table border/padding and initial/final border-spacing.
Bug: 1078927
Change-Id: If6424d961985d84495f388ff8b40aef4b2ce3034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747937
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1021348}