Fix OOF positioning when they appear in nested multi-columns #34810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 12, 2022
This patch fixes OOF positioning when they appear in nested multi-columns, with some specific conditions as seen in the attached test. This change is a partial revert of crrev.com/c/3714109. Bug: 1343167, 1343746 Change-Id: I9afc8972f2d20eb271c7a7c3d9d06beeedcaa51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3752215 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1023250}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3752215
branch
from
7f22ba2
to
c0092e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes OOF positioning when they appear in nested
multi-columns, with some specific conditions as seen in the
attached test.
This change is a partial revert of crrev.com/c/3714109.
Bug: 1343167, 1343746
Change-Id: I9afc8972f2d20eb271c7a7c3d9d06beeedcaa51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3752215
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1023250}