Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS properties to control pop-up hover behaviors #34842

Merged
merged 1 commit into from Jul 20, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 14, 2022

This CL adds these two CSS properties (which are still subject to
bikeshedding on the name):

  • hover-pop-up-delay
  • hover-pop-up-hide-delay

Both properties are time valued properties. The first controls the
delay after hovering an invoking element (using the hoverpopup
attribute) before the pop-up is triggered. The second controls the
delay after which a showing pop-up will be hidden if it isn't hovered
for a period of time. The first is connected to the behavior, the
second will be connected in a followup CL.

Discussion:
openui/open-ui#526 (comment)

Bug: 1307772
Change-Id: Ia44cbf63f91732935d620c527265129ffeb4f96b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3760885
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026338}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3760885 branch 5 times, most recently from 8e9e459 to 7e3629b Compare July 20, 2022 16:40
This CL adds these two CSS properties (which are still subject to
bikeshedding on the name):
 - hover-pop-up-delay
 - hover-pop-up-hide-delay

Both properties are time valued properties.  The first controls the
delay after hovering an invoking element (using the hoverpopup
attribute) before the pop-up is triggered. The second controls the
delay after which a showing pop-up will be hidden if it isn't hovered
for a period of time. The first is connected to the behavior, the
second will be connected in a followup CL.

Discussion:
openui/open-ui#526 (comment)

Bug: 1307772
Change-Id: Ia44cbf63f91732935d620c527265129ffeb4f96b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3760885
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026338}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants