Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css-shadow-parts: fix ::part() when element also has @exportparts #35258

Merged
merged 1 commit into from Jul 28, 2022
Merged

css-shadow-parts: fix ::part() when element also has @exportparts #35258

merged 1 commit into from Jul 28, 2022

Commits on Jul 28, 2022

  1. css-shadow-parts: fix ::part() when element also has @exportparts 

    CL:3610986 rearranges the loop in StyleResolver::MatchPseudoPartRules
to include the ::part() matching element’s own tree scope, so we can
consider :host::part() rules, but it erroneously maps part names
through @exportparts before moving to the scope directly above. As a
result, we start searching for ::part() rules with our forwarded part
names when we should be searching for rules with our own part names.

This patch defers mapping part names through @exportparts until after
the scope directly above the ::part() matching element.

Fixed: 1347634
Change-Id: Ibe369d0f9324fa9f45112d35d921511513b2b59e
    @delan @chromium-wpt-export-bot
    delan authored and chromium-wpt-export-bot committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    e222eb5 View commit details
    Browse the repository at this point in the history