Move focus-navigation tests to WPT #35387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 8, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3817589
branch
9 times, most recently
from
1e3cc4e
to
3ee8315
Compare
The current state of test_driver.send_keys and content_shell doesn't allow sequential focus navigation [1]. The current plan is to copy the existing focus-navigation tests to WPT at web_tests/external/wpt/shadow-dom/focus-navigation/ and keep the content_shell tests at web_tests/shadow-dom/focus-navigation/ for test coverage. In the future, once [2] is resolved and we can run WPT test in chrome, we can remove the duplicated tests that depends on the content_shell in web_tests/shadow-dom/focus-navigation/ and enable the web_tests/external/wpt/shadow-dom/focus-navigation/ tests. [1] whatwg/html#4151 [2] crbug.com/893480 Change-Id: Ib4232494162e19110dfb785034712d56d3ff9491 Bug: 769673, 893480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817589 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1035097}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3817589
branch
from
3ee8315
to
06bb810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state of test_driver.send_keys and content_shell doesn't
allow sequential focus navigation [1].
The current plan is to copy the existing focus-navigation tests to WPT
at web_tests/external/wpt/shadow-dom/focus-navigation/ and keep
the content_shell tests at web_tests/shadow-dom/focus-navigation/ for
test coverage.
In the future, once [2] is resolved and we can run WPT test in chrome,
we can remove the duplicated tests that depends on the content_shell
in web_tests/shadow-dom/focus-navigation/ and enable the
web_tests/external/wpt/shadow-dom/focus-navigation/ tests.
[1] whatwg/html#4151
[2] crbug.com/893480
Change-Id: Ib4232494162e19110dfb785034712d56d3ff9491
Bug: 769673, 893480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817589
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1035097}