Consistent border-spacing truncation. #35475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3829558
branch
4 times, most recently
from
55f70b7
to
0d6c631
Compare
With this change, we'll treat border-spacing pretty much like margins, as far as block fragmentation is concerned. That is, we'll now truncate them at fragmentainer boundaries. This also includes border-spacing before repeated table headers, which affects quite a few tests in fragmentation/ and printing/. Set border-spacing to 0 in some tests (and compensate by adding padding to the table cells where it makes sense, so that we don't affect the block-size of the contents too much (which would require bigger test rewrites)). Also add new tests that use non-zero border-spacing. They are marked as tentative, since exact behavior here is undefined. Bug: 1335870 Change-Id: I230d33cb165276dba044158cd97b892844bf8ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829558 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1035467}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3829558
branch
from
0d6c631
to
d4f2bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we'll treat border-spacing pretty much like margins,
as far as block fragmentation is concerned. That is, we'll now truncate
them at fragmentainer boundaries. This also includes border-spacing
before repeated table headers, which affects quite a few tests in
fragmentation/ and printing/. Set border-spacing to 0 in some tests (and
compensate by adding padding to the table cells where it makes sense, so
that we don't affect the block-size of the contents too much (which
would require bigger test rewrites)).
Also add new tests that use non-zero border-spacing. They are marked as
tentative, since exact behavior here is undefined.
Bug: 1335870
Change-Id: I230d33cb165276dba044158cd97b892844bf8ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829558
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1035467}