[Gecko Bug 1694993] Part 4: Copy session storage before loading, and only for newly created windows #35553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 22, 2022
moz-wptsync-bot
force-pushed
the
gecko/1694993
branch
from
b99feef
to
3243408
Compare
…ed windows Previously we would copy session storage even if we were not opening a new window, meaning that a targeted load could re-trigger a copy. This was not specified in the standard so is being changed to only copy when a new window is created. In addition, the copy was moved before navigaton starts, again for more consistency with ordering for the standard, such that things like `javascript:` URI loads will oberve the up-to-date session storage. Differential Revision: https://phabricator.services.mozilla.com/D154566 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1694993 gecko-commit: f2b6ca0547cbf1264b739bbced20c1aeadf5f384 gecko-reviewers: smaug
moz-wptsync-bot
force-pushed
the
gecko/1694993
branch
from
3243408
to
66def38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would copy session storage even if we were not opening a new
window, meaning that a targeted load could re-trigger a copy. This was not
specified in the standard so is being changed to only copy when a new window is
created. In addition, the copy was moved before navigaton starts, again for
more consistency with ordering for the standard, such that things like
javascript:URI loads will oberve the up-to-date session storage.Depends on D154565
Differential Revision: https://phabricator.services.mozilla.com/D154566
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1694993
gecko-commit: 3b412d5fbdcfec899bb81bcc6e298c0333dd14b5
gecko-reviewers: smaug