Align WebRTC MTI stats with specs #35703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron,
snuggs and
youennf
henbos
reviewed
Aug 30, 2022
| "framesDropped" | ||
| ], | ||
| RTCInboundRtpStreamStats: [ | ||
| "receiverId", | ||
| "trackIdentifiedId", |
There was a problem hiding this comment.
Typo: should be trackIdentifier
There was a problem hiding this comment.
fixed in 8ae7fbe
| @@ -23,18 +23,18 @@ | |||
| "packetsReceived", | |||
| "packetsLost", | |||
| "jitter", | |||
| "packetsDiscarded", | |||
| "framesDropped" | |||
| ], | |||
| RTCInboundRtpStreamStats: [ | |||
There was a problem hiding this comment.
Not a WPT question, but this does make me wonder if inbound-rtp.mid and outbound-rtp.mid should be "mandatory to implement", but that ship may have sailed already
henbos
approved these changes
Aug 30, 2022
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see w3c/webrtc-pc#2744 w3c/webrtc-pc#2748 w3c/webrtc-stats#647