Parsing all selectors unforgiving way for @supports selector() #35770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 2, 2022
chromium-wpt-export-bot
changed the title
@supports selector()
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3872106
branch
from
5b19be3
to
b06c9f1
Compare
chromium-wpt-export-bot
changed the title
@supports selector()
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3872106
branch
6 times, most recently
from
ea90080
to
6c11931
Compare
To detect errors in forgiving parsing selectors (e.g. :is(), :has()) with '@supports selector()', CSSSelectorParser parses all selectors unforgiving way to raise error while checking the selectors with '@supports selector()` according to the csswg issue resolution: - csswg-drafts/issues/7280#issuecomment-1143852187 An experimental feature flag 'CSSAtSupportsAlwaysNonForgivingParsing' is added to enable this behavior when the experimental-web-platform- features flag is enabled. This is the chrome platform feature for the flag: - https://chromestatus.com/feature/6177049203441664 Bug: 1358953, 1359396 Change-Id: If203c8d6124edbf67b1ebf0f58cf1a01b31c90a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3872106 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Byungwoo Lee <blee@igalia.com> Cr-Commit-Position: refs/heads/main@{#1043758}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3872106
branch
from
6c11931
to
c7b92a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect errors in forgiving parsing selectors (e.g. :is(), :has())
with '@supports selector()', CSSSelectorParser parses all selectors
unforgiving way to raise error while checking the selectors with
'@supports selector()` according to the csswg issue resolution:
An experimental feature flag 'CSSAtSupportsAlwaysNonForgivingParsing'
is added to enable this behavior when the experimental-web-platform-
features flag is enabled.
This is the chrome platform feature for the flag:
Bug: 1358953, 1359396
Change-Id: If203c8d6124edbf67b1ebf0f58cf1a01b31c90a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3872106
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Byungwoo Lee <blee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1043758}