Handle font-size -> registered var -> line-height cycles #35963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 20, 2022
Code behaved correctly, but use the separate HasLineHeightUnits instead of adding the lh unit to IsFontUnitToken. Added test. Bug: 937104 Change-Id: I25cfc4100d80658137defb9a341f99d6e8fdb6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904405 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1049043}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3904405
branch
from
abd0268
to
2bbd14d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code behaved correctly, but use the separate HasLineHeightUnits instead
of adding the lh unit to IsFontUnitToken.
Added test.
Bug: 937104
Change-Id: I25cfc4100d80658137defb9a341f99d6e8fdb6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904405
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1049043}