[Gecko Bug 1246657] The Operator Dictionary lack entries for U+1EEF0 and U+1EEF1. #36043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the following operators use category I from MathML Core's operator dictionary [1] [2]: U+1EEF0 ARABIC MATHEMATICAL OPERATOR MEEM WITH HAH WITH TATWEEL U+1EEF1 ARABIC MATHEMATICAL OPERATOR HAH WITH DAL which corresponds to zero lspace/rspace and stretchy. There should already be exhaustive WPT tests operator-dictionary-* to check these and other properties, but they may be shadowed by existing failures or Firefox bugs, so add some more specific reftests for spacing and stretching. However, nsMathMLmoFrame and nsMathMLChar don't handle non-BMP characters very well, so only the first one currently passes. Also tweak updateOperatorDictionary.pl to ignore these special operators. [1] https://w3c.github.io/mathml-core/#dfn-algorithm-to-determine-the-category-of-an-operator [2] https://w3c.github.io/mathml-core/#operator-dictionary-categories-values Differential Revision: https://phabricator.services.mozilla.com/D157788 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1246657 gecko-commit: c9ca9a0093c9ad8234abc221dcb4f93398c80989 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the following operators use category I from
MathML Core's operator dictionary [1] [2]:
U+1EEF0 ARABIC MATHEMATICAL OPERATOR MEEM WITH HAH WITH TATWEEL
U+1EEF1 ARABIC MATHEMATICAL OPERATOR HAH WITH DAL
which corresponds to zero lspace/rspace and stretchy. There should
already be exhaustive WPT tests operator-dictionary-* to check
these and other properties, but they may be shadowed by existing
failures or Firefox bugs, so add some more specific reftests for
spacing and stretching. However, nsMathMLmoFrame and nsMathMLChar
don't handle non-BMP characters very well, so only the first one
currently passes.
Also tweak updateOperatorDictionary.pl to ignore these special
operators.
[1] https://w3c.github.io/mathml-core/#dfn-algorithm-to-determine-the-category-of-an-operator
[2] https://w3c.github.io/mathml-core/#operator-dictionary-categories-values
Differential Revision: https://phabricator.services.mozilla.com/D157788
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1246657
gecko-commit: c9ca9a0093c9ad8234abc221dcb4f93398c80989
gecko-reviewers: emilio