Update backgrounds on transformed root element tests #36306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
requested review from
grorg,
plinss and
dirkschulze
and removed request for
grorg,
dirkschulze and
plinss
|
I haven't touched css/css-transforms/transform-translate-background-001.html or css/css-transforms/transform-translate-background-002.html because the expected results are a bit more unclear, but those tests also need updating. |
nt1m
force-pushed
the
transforms-root-bg
branch
4 times, most recently
from
9588d84
to
13e51ca
Compare
dbaron
approved these changes
Oct 6, 2022
nt1m
force-pushed
the
transforms-root-bg
branch
from
13e51ca
to
323d872
Compare
It was decided that transforms on the root element and on the canvas should not apply to the background-image. See: w3c/csswg-drafts#6683 (comment)
nt1m
force-pushed
the
transforms-root-bg
branch
from
323d872
to
e0e54eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided that transforms on the root element and on the canvas should not apply to the background-image.
See: w3c/csswg-drafts#6683 (comment)