New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gecko Bug 1791778] Add WPT test for the interaction of font-palette and the font shorthand. #36328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently fails in webkit & blink; w3c/csswg-drafts#7832 asks the CSS WG to confirm whether to keep the existing spec (which is what's implemented here) or change it to match those implementations (in which case we'll need to do a minor followup to tweak our behavior accordingly). Differential Revision: https://phabricator.services.mozilla.com/D158787 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791778 gecko-commit: 8e023280032c8b32c1eaeaf595c2eb989a4427f3 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Firefox project.
…791777) for causing multiple mochitest failures CLOSED TREE Backed out changeset 6de1ade5a9b6 (bug 1791782) Backed out changeset ce96452a38a1 (bug 1791782) Backed out changeset 7cc8e027f5a7 (bug 1791780) Backed out changeset 8e023280032c (bug 1791778) Backed out changeset 26d65d76d02a (bug 1791778) Backed out changeset a98dd552df64 (bug 1791777) Backed out changeset 766386309ee5 (bug 1791777) Backed out changeset 7de66a218ba4 (bug 1791777) Backed out changeset 1d17c257444e (bug 1791777) gecko-commit: 95e88e50554a28094551439c92302ff79ec254a5
This currently fails in webkit & blink; w3c/csswg-drafts#7832 asks the CSS WG to confirm whether to keep the existing spec (which is what's implemented here) or change it to match those implementations (in which case we'll need to do a minor followup to tweak our behavior accordingly). Differential Revision: https://phabricator.services.mozilla.com/D158787 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791778 gecko-commit: 4e4eb99a7fd95b2e288e478b5d97019b259ada91 gecko-reviewers: emilio
…791782) for causing build bustages on TestCOLRv1.cpp CLOSED TREE Backed out changeset f145a34cfbc1 (bug 1791782) Backed out changeset 2f12216fbeda (bug 1791782) Backed out changeset 61bd2a4496bf (bug 1791780) Backed out changeset 4e4eb99a7fd9 (bug 1791778) Backed out changeset 32d171a28810 (bug 1791778) Backed out changeset e317795cd27a (bug 1791777) Backed out changeset 5e32d5a01917 (bug 1791777) Backed out changeset cf87497dbead (bug 1791777) Backed out changeset 586c735b005e (bug 1791777) gecko-commit: 26719673db5f17ab7b1a8f945c4c361f039cec0a
This currently fails in webkit & blink; w3c/csswg-drafts#7832 asks the CSS WG to confirm whether to keep the existing spec (which is what's implemented here) or change it to match those implementations (in which case we'll need to do a minor followup to tweak our behavior accordingly). Differential Revision: https://phabricator.services.mozilla.com/D158787 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791778 gecko-commit: 528b4c022a44e15cd66ef9dca54e7e67c89e2ba4 gecko-reviewers: emilio
…791777) for causing build bustages in TestCOLRv1.cpp CLOSED TREE Backed out changeset aeb44b79bf31 (bug 1791782) Backed out changeset 292fd3a1b6dd (bug 1791782) Backed out changeset 9947218170d0 (bug 1791780) Backed out changeset 528b4c022a44 (bug 1791778) Backed out changeset c734ff661a66 (bug 1791778) Backed out changeset 6585dd386ee3 (bug 1791777) Backed out changeset af4243189ef1 (bug 1791777) Backed out changeset a47ae5f76514 (bug 1791777) Backed out changeset 24ce615e77fd (bug 1791777) gecko-commit: f1accadf1754ad5aa8d668ecb22ec8ef1a5bd880
This currently fails in webkit & blink; w3c/csswg-drafts#7832 asks the CSS WG to confirm whether to keep the existing spec (which is what's implemented here) or change it to match those implementations (in which case we'll need to do a minor followup to tweak our behavior accordingly). Differential Revision: https://phabricator.services.mozilla.com/D158787 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791778 gecko-commit: 2b445c555e746e572a28e612452ef26d2ecfb9e8 gecko-reviewers: emilio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails in webkit & blink; w3c/csswg-drafts#7832 asks the CSS WG to confirm
whether to keep the existing spec (which is what's implemented here) or change it to match those implementations
(in which case we'll need to do a minor followup to tweak our behavior accordingly).
Differential Revision: https://phabricator.services.mozilla.com/D158787
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791778
gecko-commit: 8e023280032c8b32c1eaeaf595c2eb989a4427f3
gecko-reviewers: emilio