[Gecko Bug 1799216] Keep clip chain id in sync when switching items that affect clip positioning. #36837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tioning. Bug 1661147 made us correctly inherit the clip chain. We do fix up the scroll id etc before pushing a new ASR override etc, but we didn't fix up the clip chain ID. Differential Revision: https://phabricator.services.mozilla.com/D161382 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1799216 gecko-commit: 2d53a4acaad28c95bc1a19d05b379bf25f850be0 gecko-reviewers: gfx-reviewers, gw
wpt-pr-bot
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1661147 made us correctly inherit the clip chain. We do fix up the
scroll id etc before pushing a new ASR override etc, but we didn't fix
up the clip chain ID.
Differential Revision: https://phabricator.services.mozilla.com/D161382
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1799216
gecko-commit: 2d53a4acaad28c95bc1a19d05b379bf25f850be0
gecko-reviewers: gfx-reviewers, gw