Include trailing border/padding/border-spacing in table block-size. #36887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 9, 2022
Even if we know that we're going to break inside, FinishFragmentation() needs this in order to behave correctly. All other layout algorithms should also do this, and that's usually trivial, but it's complicated for tables, because we don't have proper internal separation between the table box and the table wrapper box (which is supposed to contain any captions in addition to the table box). Bug: 1357123 Change-Id: I1df5d3cabe540985f7539387b3ceda60ac80da2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016674 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1069659}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4016674
branch
from
2f0e0ce
to
1aaac65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we know that we're going to break inside, FinishFragmentation()
needs this in order to behave correctly. All other layout algorithms
should also do this, and that's usually trivial, but it's complicated
for tables, because we don't have proper internal separation between the
table box and the table wrapper box (which is supposed to contain any
captions in addition to the table box).
Bug: 1357123
Change-Id: I1df5d3cabe540985f7539387b3ceda60ac80da2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016674
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1069659}