Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test for calc together with aspect-ratio in media queries #36889

Merged

Conversation

romainmenke
Copy link
Contributor

@romainmenke romainmenke commented Nov 9, 2022

WebKit :

Blink :

Gecko :

  • passes

Maybe this needs even more tests for :

  • calc() / <not-calc>
  • <not-calc> / calc()
  • calc() / calc()

But I am assuming that any support for calc() will cover all cases.

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one suggestion.

<head>
<title>Test: support for calc in Media Queries</title>
<link rel="author" title="Romain Menke" href="https://github.com/romainmenke">
<link rel="help" href="http://www.w3.org/TR/css3-values/#calc-notation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to add two additional links here:
https://drafts.csswg.org/css-values-4/#ratios
w3c/csswg-drafts#3757

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dbaron, I've added these links.

@dbaron dbaron merged commit 89689e1 into web-platform-tests:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants