Don't expand the last column set if we miss it in the first place. #36891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 9, 2022
If we haven't set it up correctly anyway (because the column set shouldn't even be there), just give up. This is a work-around for an old legacy bug, which we can hopefully just live with until the legacy engine is completely gone. Bug: 1373409 Change-Id: I97ff5135e74be66b3c9f3f13b038ecfb7263f168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016452 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1069487}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4016452
branch
from
e0e15dc
to
90770a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we haven't set it up correctly anyway (because the column set
shouldn't even be there), just give up. This is a work-around for an old
legacy bug, which we can hopefully just live with until the legacy
engine is completely gone.
Bug: 1373409
Change-Id: I97ff5135e74be66b3c9f3f13b038ecfb7263f168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016452
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1069487}