Animate font-style #37570
Merged
Animate font-style #37570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 18, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4096787
branch
2 times, most recently
from
74f2d47
to
18f86bf
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4096787
branch
4 times, most recently
from
338bc55
to
78bf926
Compare
Animating CSS property font-style to be smoothly transitioned in the style change. https://www.w3.org/TR/css-fonts-4/#propdef-font-style Bug: 1064946 Change-Id: I216ace9e497e679a126c6519592b5a64d4ed0993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096787 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1088665}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4096787
branch
from
78bf926
to
c7f0815
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 6, 2023
…eg'. r=firefox-style-system-reviewers,emilio This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 7, 2023
…eg'. r=firefox-style-system-reviewers,emilio This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jan 13, 2023
…eg'. r=firefox-style-system-reviewers,emilio This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jan 13, 2023
…eg'. r=firefox-style-system-reviewers,emilio This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 2, 2023
This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 3, 2023
This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 3, 2023
This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
mrobinson
pushed a commit
to servo/servo
that referenced
this pull request
Nov 4, 2023
This matches what the spec[1] says for font-style: > Animation type: by computed value type; normal animates as oblique 0deg A bunch of WPT tests for font-style animation are landing in web-platform-tests/wpt#37570. Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Differential Revision: https://phabricator.services.mozilla.com/D166128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animating CSS property font-style to be smoothly transitioned in the
style change.
https://www.w3.org/TR/css-fonts-4/#propdef-font-style
Bug: 1064946
Change-Id: I216ace9e497e679a126c6519592b5a64d4ed0993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096787
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Munira Tursunova <moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1088665}