[Sub Apps] Limit add() calls to at most 7 apps #37732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 3, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4127312
branch
3 times, most recently
from
752681f
to
06a100e
Compare
To avoid overwhelming the user with an overloaded permissions prompt, only allow 7 apps to be added at once. Bug: 1402192 Test: third_party/blink/tools/run_web_tests.py external/wpt/subapps Change-Id: I7ebb34c3700fdbf1b699debe78228d3bc4b889cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127312 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Philipp Weiß <phweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#1090745}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4127312
branch
from
06a100e
to
efca142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid overwhelming the user with an overloaded permissions prompt,
only allow 7 apps to be added at once.
Bug: 1402192
Test: third_party/blink/tools/run_web_tests.py external/wpt/subapps
Change-Id: I7ebb34c3700fdbf1b699debe78228d3bc4b889cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127312
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Philipp Weiß <phweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090745}