VT: End the transition only if animation is not running or paused #37852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 10, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4150115
branch
2 times, most recently
from
872ada7
to
36e64f3
Compare
Instead of effect IsCurrent, the spec says we should check animation run state and whether it's running or paused. This change aligns with the spec R=khushalsagar@chromium.org Fixed: 1392138 Change-Id: I7dcc316ee5c2d20b1e824e7a21a8f4a5859a8ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4150115 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1090996}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4150115
branch
from
36e64f3
to
748f8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of effect IsCurrent, the spec says we should check animation
run state and whether it's running or paused. This change aligns with
the spec
R=khushalsagar@chromium.org
Fixed: 1392138
Change-Id: I7dcc316ee5c2d20b1e824e7a21a8f4a5859a8ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4150115
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090996}