[CQ] Respect contain:style in ListItemOrdinal #37900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 12, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4161712
branch
from
efdd152
to
b07cfb4
Compare
In e.g. a reversed list with automatic ordinals, the style recalc of an element may cause invalidation of "previous" LayoutObjects. If this happens during interleaved style recalc, then we may dirty LayoutObjects that we're already done laying out. This CL addresses this by considering style containment during ordinal calculations in ListItemOrdinal. Instead of always considering the enclosing list as the scope for the current counter, we now also treat intermediate elements with contain:style as such. Fixed: 1377644 Change-Id: I7d4d9e7fd84e061a28ae40f3bae280b9d55558a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161712 Reviewed-by: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1092264}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4161712
branch
from
b07cfb4
to
588beea
Compare
|
Looks transient: #37918 (comment). Retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e.g. a reversed list with automatic ordinals, the style recalc of
an element may cause invalidation of "previous" LayoutObjects.
If this happens during interleaved style recalc, then we may dirty
LayoutObjects that we're already done laying out.
This CL addresses this by considering style containment during
ordinal calculations in ListItemOrdinal. Instead of always considering
the enclosing list as the scope for the current counter, we now also
treat intermediate elements with contain:style as such.
Fixed: 1377644
Change-Id: I7d4d9e7fd84e061a28ae40f3bae280b9d55558a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161712
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092264}