Add aftertoggle event for popover
#37915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 12, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4160443
branch
from
71fa5de
to
76ef3b1
Compare
This CL adds an async `aftertoggle` event to both the show and hide popover transitions, and renames the event class from BeforeToggle to PopoverToggle, to be used by both events. This was resolved by OpenUI here: openui/open-ui#342 (comment) Bug: 1307772 Change-Id: I996be74b90f43eee4bf859cecfed051fa6f633d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4160443 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1092158}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4160443
branch
from
76ef3b1
to
5e5c772
Compare
|
Looks transient: #37918 (comment). Retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds an async
aftertoggleevent to both the show and hidepopover transitions, and renames the event class from BeforeToggle
to PopoverToggle, to be used by both events.
This was resolved by OpenUI here:
openui/open-ui#342 (comment)
Bug: 1307772
Change-Id: I996be74b90f43eee4bf859cecfed051fa6f633d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4160443
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092158}