[Gecko Bug 1808995] Fix WPT testcases that do not properly account for counter-style fallback behavior of prefix/suffix descriptors. #38219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 27, 2023
…back behavior of prefix/suffix descriptors. Per spec, "If a counter style is used to represent a counter value outside of its ranges, the counter style instead drops down to its fallback counter style." https://www.w3.org/TR/css-counter-styles-3/#counter-style-range https://www.w3.org/TR/css-counter-styles-3/#counter-style-fallback Some existing tests incorrectly assumed that a prefix or suffix from a custom rule will still apply even when the counter value is not in range. That would mean "fallback" is only partial, using the symbols/system from the fallback style mixed with the prefix/suffix of the originally-specified style, which prevents use-cases like that in bug 1808995 working as expected. Differential Revision: https://phabricator.services.mozilla.com/D167410 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1808995 gecko-commit: ed181fad393482cfd7961b1aa9d322da8009b485 gecko-reviewers: emilio
…tom style's range. Differential Revision: https://phabricator.services.mozilla.com/D167411 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1808995 gecko-commit: f43c5a2967b47dd473b7f55430dc4937ef735770 gecko-reviewers: emilio
…k chain. Differential Revision: https://phabricator.services.mozilla.com/D168051 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1808995 gecko-commit: 809ead0307798a50c8e9a8fb968b6100f4200d66 gecko-reviewers: emilio
moz-wptsync-bot
force-pushed
the
gecko/1808995
branch
from
bcb1f49
to
430b9c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec, "If a counter style is used to represent a counter value outside of its ranges,
the counter style instead drops down to its fallback counter style."
https://www.w3.org/TR/css-counter-styles-3/#counter-style-range
https://www.w3.org/TR/css-counter-styles-3/#counter-style-fallback
Some existing tests incorrectly assumed that a prefix or suffix from a custom rule will still apply
even when the counter value is not in range. That would mean "fallback" is only partial, using
the symbols/system from the fallback style mixed with the prefix/suffix of the originally-specified
style, which prevents use-cases like that in bug 1808995 working as expected.
Differential Revision: https://phabricator.services.mozilla.com/D167410
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1808995
gecko-commit: c2a49ee389d95fef709a326f089033aa362543aa
gecko-reviewers: emilio