Make the canvas size parameterizable in generated WPT tests. #38286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 31, 2023
Right now, the "canvas" template parameter was used for both specifying custom attributes for the canvas tag, but also for specifying the size. Having dedicated parameters for the canvas size makes it possible to customize the size for both element and and offscreen tests. Bug: 1409873 Change-Id: I63a550d90871f25a9dcc00a2b4f6ceff5c916d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208909 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1099918}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4208909
branch
from
986ee11
to
c5314fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the "canvas" template parameter was used for both specifying
custom attributes for the canvas tag, but also for specifying the size.
Having dedicated parameters for the canvas size makes it possible to
customize the size for both element and and offscreen tests.
Bug: 1409873
Change-Id: I63a550d90871f25a9dcc00a2b4f6ceff5c916d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208909
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1099918}