[WebCodecs] Fix crossOriginSource VideoFrame tests. #38312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 2, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4214277
branch
2 times, most recently
from
54db9ee
to
a5bd7c1
Compare
- SVGImageElement.crossOrigin isn't standardized, so set correct expectations if it's not available. - onloadeddata doesn't mean a VideoFrame is available, so use requestVideoFrameCallback if available. This exposed a bug in rVFC for hidden preload=metadata elements which is also fixed. R=tguilbert Bug: 1412203 Change-Id: Ic6436c08723f0d46b71ee456d436a32f1daaf26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4214277 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100620}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4214277
branch
from
a5bd7c1
to
d9a5c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectations if it's not available.
requestVideoFrameCallback if available.
This exposed a bug in rVFC for hidden preload=metadata elements
which is also fixed.
R=tguilbert
Bug: 1412203
Change-Id: Ic6436c08723f0d46b71ee456d436a32f1daaf26c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4214277
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1100620}