Remove NOTREACHED in HttpCache::Transaction #38326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 2, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4218212
branch
from
2ce3a12
to
24ea84f
Compare
net::HttpCache::Transaction::BeginCacheRead had a NOTREACHED() statement which is reached if a range request is sent with "only-if-cached" as the cache mode. Remove the NOTREACHED() and permit the fallthrough behaviour of returning ERR_CACHE_MISS to happen instead. Add unit and web-platform tests for this case. The wpt fails because it expects the fetch to succeed, whereas our implementation returns ERR_CACHE_MISS. BUG=1408233 Change-Id: I1023712b1a0d3642e6c980dd12dba81440d4fc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218212 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100870}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4218212
branch
from
24ea84f
to
67d29fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net::HttpCache::Transaction::BeginCacheRead had a NOTREACHED() statement
which is reached if a range request is sent with "only-if-cached" as the
cache mode.
Remove the NOTREACHED() and permit the fallthrough behaviour of
returning ERR_CACHE_MISS to happen instead.
Add unit and web-platform tests for this case. The wpt fails because it
expects the fetch to succeed, whereas our implementation returns
ERR_CACHE_MISS.
BUG=1408233
Change-Id: I1023712b1a0d3642e6c980dd12dba81440d4fc13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218212
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1100870}