Add anchorElement element reference IDL #38355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 3, 2023
The anchor content attribute is not currently reflected in IDL. This CL
adds IDL reflection, as an element reference:
```
popover.anchorElement = myElement;
popover.setAttribute('anchor','idref');
const el = popover.anchorElement;
```
This is gated behind the CSSAnchorPositioning flag, since it is most
closely associated with that feature.
Bug: 1307772,1309178
Change-Id: I7c4d54d94ad5eeb38d1945733bbbaa3890f2b5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209776
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1101192}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4209776
branch
from
4f05c20
to
18e6707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anchor content attribute is not currently reflected in IDL. This CL
adds IDL reflection, as an element reference:
This is gated behind the CSSAnchorPositioning flag, since it is most
closely associated with that feature.
Bug: 1307772,1309178
Change-Id: I7c4d54d94ad5eeb38d1945733bbbaa3890f2b5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209776
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1101192}