[Gecko Bug 1814074] Make AutoDeleteRangesHandler::ExtendOrShrinkRangeToDelete consider whether all list items are selected more carefully
#38487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whether all list items are selected more carefully It currently check range boundaries are start/end of a list element. However, there are a lot of cases. E.g., selection can starts and/or ends inner position due to invisible white-spaces and sub-lists. The expectations of the new tests are based on Chrome's result. However, unfortunately, the joining result of sub-lists is different from Chrome. Therefore, they fail. (Gecko makes each list element has one list item.) Differential Revision: https://phabricator.services.mozilla.com/D169037 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1814074 gecko-commit: b57b0356d5ddc81da52ec7c81343fb3516c09eaa gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently check range boundaries are start/end of a list element. However,
there are a lot of cases. E.g., selection can starts and/or ends inner
position due to invisible white-spaces and sub-lists.
The expectations of the new tests are based on Chrome's result. However,
unfortunately, the joining result of sub-lists is different from Chrome.
Therefore, they fail. (Gecko makes each list element has one list item.)
Differential Revision: https://phabricator.services.mozilla.com/D169037
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1814074
gecko-commit: b57b0356d5ddc81da52ec7c81343fb3516c09eaa
gecko-reviewers: m_kato