[Gecko Bug 1816039] Make HTMLEditor handle selection ranges which starts from or ends in `<foo inert
#38533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `<foo inert According to the WPTs and their result in the other browsers, we should: * do not work with a range anchored from a node in an element which has `inert`. * collapse the range first when it ends at a node in an element which has `inert`. See new WPT for the detail. Note that `inert` with `contenteditable` must not be so major cases. Therefore, this patch does not fix the edge cases like the `nsFrameSelection` use cases and replacing `Selection` cases of the other edit commands/operations. Depends on D169037 Differential Revision: https://phabricator.services.mozilla.com/D169743 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1816039 gecko-commit: e91291cda07a215c99f1b36e8d8d1e28935a0d9e gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the WPTs and their result in the other browsers, we should:
inert.inert.See new WPT for the detail.
Note that
inertwithcontenteditablemust not be so major cases. Therefore,this patch does not fix the edge cases like the
nsFrameSelectionuse casesand replacing
Selectioncases of the other edit commands/operations.Depends on D169037
Differential Revision: https://phabricator.services.mozilla.com/D169743
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1816039
gecko-commit: e91291cda07a215c99f1b36e8d8d1e28935a0d9e
gecko-reviewers: m_kato