[Gecko Bug 1780865] Make scroll timeline inactive if there is not scroll range. #38543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per spec issue: w3c/csswg-drafts#7401, and the updated spec words: If the source of a ScrollTimeline is an element whose principal box does not exist or is not a scroll container, or if there is no scrollable overflow, then the ScrollTimeline is inactive. Besides, it seems we may have other issues related to Bug 1817051, so I update the wpt to avoid testing the animation sampling times per frame. Differential Revision: https://phabricator.services.mozilla.com/D169995 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780865 gecko-commit: 92f2277707fbcd1dcf622181bc00269d2a13ca7d gecko-reviewers: hiro
wpt-pr-bot
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec issue: w3c/csswg-drafts#7401, and the
updated spec words:
If the source of a ScrollTimeline is an element whose principal box does
not exist or is not a scroll container, or if there is no scrollable overflow,
then the ScrollTimeline is inactive.
Besides, it seems we may have other issues related to Bug 1817051, so I
update the wpt to avoid testing the animation sampling times per frame.
Differential Revision: https://phabricator.services.mozilla.com/D169995
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780865
gecko-commit: 92f2277707fbcd1dcf622181bc00269d2a13ca7d
gecko-reviewers: hiro