[Gecko Bug 1822907] part 2: When handling a content-visibility change, don't insert already-completed animations into the timeline's sampling-order list. #39156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy-completed animations into the timeline's sampling-order list. We have an invariant that the mAnimationOrder LinkedList is a subset of the mAnimations hashset (omitting any animations that are hidden due to content-visibility). This patch corrects one case where we were incorrectly inserting an animation into the linked list when it wasn't present in the hashset (because the animation had completed). This patch also adds some documentation to mention this invariant, and some assertions to enforce it in several places. Differential Revision: https://phabricator.services.mozilla.com/D173333 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1822907 gecko-commit: 74d3d5d35e7767882de82d40ca7aa4f3d85b488a gecko-reviewers: hiro
wpt-pr-bot
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an invariant that the mAnimationOrder LinkedList is a subset of the
mAnimations hashset (omitting any animations that are hidden due to
content-visibility). This patch corrects one case where we were incorrectly
inserting an animation into the linked list when it wasn't present in the
hashset (because the animation had completed).
This patch also adds some documentation to mention this invariant, and some
assertions to enforce it in several places.
Differential Revision: https://phabricator.services.mozilla.com/D173333
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1822907
gecko-commit: 74d3d5d35e7767882de82d40ca7aa4f3d85b488a
gecko-reviewers: hiro