[Gecko Bug 1737920] Part 3: Look up named view timeline for CSS animations and update WPT expectations. #39509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expectations. Disable OMTA support for now. We have to make sure what should we do when the subject is scrolled to "out of view" on the compositor, in Bug 1818346. And we have to make sure view-timeline-inset animation work well on the compositor. Also, update tests, 1) timeline-offset-keyframes-hidden-subject.html, and 2) view-timeline-keyframe-boundary-interpolation.html, to avoid js error because Gecko doesn't expose Animation object with scroll-timeline or view-timeline. And update test, view-timeline-lookup.html, because scroll progress timelines take precedence over view progress timelines (i.e. choose the matched scroll progress timeline first), per the spec in https://drafts.csswg.org/scroll-animations-1/#timeline-scope. Differential Revision: https://phabricator.services.mozilla.com/D170004 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1737920 gecko-commit: 15841f7c7d94c52c023012b0c085574178198027 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable OMTA support for now. We have to make sure what should we do when
the subject is scrolled to "out of view" on the compositor, in Bug 1818346.
And we have to make sure view-timeline-inset animation work well on the
compositor.
Also, update tests,
to avoid js error because Gecko doesn't expose Animation object with
scroll-timeline or view-timeline.
And update test, view-timeline-lookup.html, because scroll progress timelines
take precedence over view progress timelines (i.e. choose the matched scroll
progress timeline first), per the spec in
https://drafts.csswg.org/scroll-animations-1/#timeline-scope.
Differential Revision: https://phabricator.services.mozilla.com/D170004
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1737920
gecko-commit: 15841f7c7d94c52c023012b0c085574178198027
gecko-reviewers: emilio